lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 075/102] iio:accel:mxc4005: rearrange iio trigger get and register
    Date
    From: Dmitry Rokosov <DDRokosov@sberdevices.ru>

    commit 9354c224c9b4f55847a0de3e968cba2ebf15af3b upstream.

    IIO trigger interface function iio_trigger_get() should be called after
    iio_trigger_register() (or its devm analogue) strictly, because of
    iio_trigger_get() acquires module refcnt based on the trigger->owner
    pointer, which is initialized inside iio_trigger_register() to
    THIS_MODULE.
    If this call order is wrong, the next iio_trigger_put() (from sysfs
    callback or "delete module" path) will dereference "default" module
    refcnt, which is incorrect behaviour.

    Fixes: 47196620c82f ("iio: mxc4005: add data ready trigger for mxc4005")
    Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
    Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
    Link: https://lore.kernel.org/r/20220524181150.9240-4-ddrokosov@sberdevices.ru
    Cc: <Stable@vger.kernel.org>
    Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/iio/accel/mxc4005.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/iio/accel/mxc4005.c
    +++ b/drivers/iio/accel/mxc4005.c
    @@ -461,8 +461,6 @@ static int mxc4005_probe(struct i2c_clie
    data->dready_trig->dev.parent = &client->dev;
    data->dready_trig->ops = &mxc4005_trigger_ops;
    iio_trigger_set_drvdata(data->dready_trig, indio_dev);
    - indio_dev->trig = data->dready_trig;
    - iio_trigger_get(indio_dev->trig);
    ret = devm_iio_trigger_register(&client->dev,
    data->dready_trig);
    if (ret) {
    @@ -470,6 +468,8 @@ static int mxc4005_probe(struct i2c_clie
    "failed to register trigger\n");
    return ret;
    }
    +
    + indio_dev->trig = iio_trigger_get(data->dready_trig);
    }

    return devm_iio_device_register(&client->dev, indio_dev);

    \
     
     \ /
      Last update: 2022-06-27 13:28    [W:4.065 / U:0.668 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site