Messages in this thread | | | Date | Mon, 27 Jun 2022 16:44:43 +0700 | Subject | Re: [PATCH] ARM: dts: aspeed: Add device tree for Ampere's Mt. Mitchell BMC | From | Quan Nguyen <> |
| |
On 27/06/2022 16:35, Krzysztof Kozlowski wrote: > On 27/06/2022 11:32, Quan Nguyen wrote: >>>> + >>>> + ltc2497_reg: ltc2497_regulator { >>> >>> No underscores in node name, no specific names (Devicetree spec requires >>> generic), so ltc2497 has to go. You could add some more specific >>> prefix/suffix to describe the function. >>> >> This is to monitor peripheral voltage so it would be updated to: > > But it is a regulator, not a voltage monitor, so the node name could be: > regulator-0 > regulator-voltage-mon > voltage-mon-regulator > Yes, I think I would pick the voltage-mon-regulator:
voltage_mon_reg: voltage-mon-monitor {
>> >> voltage_monitor: voltage-monitor { >> >>>> + compatible = "regulator-fixed"; >>>> + regulator-name = "ltc2497_reg"; >>>> + regulator-min-microvolt = <3300000>; >>>> + regulator-max-microvolt = <3300000>; >>>> + regulator-always-on; >>>> + }; >>>> + > > Thanks a lot for the quick suggestion. - Quan
| |