Messages in this thread | | | Date | Mon, 27 Jun 2022 10:33:17 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v1 11/11] mfd: intel_soc_pmic_bxtwc: Fix spelling in the comment |
| |
On Thu, 16 Jun 2022, Andy Shevchenko wrote:
> There are a couple of spelling issues in the comment, fix them. > While at it, fix indentation in the MODULE_AUTHOR() parameter > and update copyright years. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/mfd/intel_soc_pmic_bxtwc.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/mfd/intel_soc_pmic_bxtwc.c b/drivers/mfd/intel_soc_pmic_bxtwc.c > index 953f535a3c93..9e412d1d00f1 100644 > --- a/drivers/mfd/intel_soc_pmic_bxtwc.c > +++ b/drivers/mfd/intel_soc_pmic_bxtwc.c > @@ -2,7 +2,7 @@ > /* > * MFD core driver for Intel Broxton Whiskey Cove PMIC > * > - * Copyright (C) 2015 Intel Corporation. All rights reserved. > + * Copyright (C) 2015-2017, 2022 Intel Corporation. All rights reserved.
I do not profess to be an expert. What happened between 2017-2022?
> */ > > #include <linux/acpi.h> > @@ -527,11 +527,11 @@ static int bxtwc_probe(struct platform_device *pdev) > return dev_err_probe(dev, ret, "Failed to add devices\n"); > > /* > - * There is known hw bug. Upon reset BIT 5 of register > + * There is known HW bug. Upon reset BIT 5 of register
You may as well fix the grammar while you're at it.
> * BXTWC_CHGR_LVL1_IRQ is 0 which is the expected value. However, > * later it's set to 1(masked) automatically by hardware. So we > - * have the software workaround here to unmaksed it in order to let > - * charger interrutp work. > + * have the software workaround here to unmasked it in order to let > + * charger interrupt work.
Likewise.
> */ > regmap_update_bits(pmic->regmap, BXTWC_MIRQLVL1, BXTWC_MIRQLVL1_MCHGR, 0); > > @@ -584,4 +584,4 @@ static struct platform_driver bxtwc_driver = { > module_platform_driver(bxtwc_driver); > > MODULE_LICENSE("GPL v2"); > -MODULE_AUTHOR("Qipeng Zha<qipeng.zha@intel.com>"); > +MODULE_AUTHOR("Qipeng Zha <qipeng.zha@intel.com>");
-- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |