Messages in this thread | | | Subject | Re: [PATCH v2 3/3] arch/*/: remove CONFIG_VIRT_TO_BUS | From | Michael Schmitz <> | Date | Mon, 27 Jun 2022 20:09:46 +1200 |
| |
Arnd,
Am 26.06.2022 um 20:36 schrieb Arnd Bergmann: >> There are no platform specific header files other than asm/amigahw.h and >> asm/mvme147hw.h, currently only holding register address definitions. >> Would it be OK to add m68k_virt_to_bus() in there if it can't remain in >> asm/virtconvert.h, Geert? > > In that case, I would just leave it under the current name and not change > m68k at all. I don't like the m68k_virt_to_bus() name because there is > not anything CPU specific in what it does, and keeping it in a common > header does nothing to prevent it from being used on other platforms > either.
Fair enough.
>>>> 32bit powerpc is a different matter though. >>> >>> It's similar, but unrelated. The two apple ethernet drivers >>> (bmac and mace) can again either get changed to use the >>> dma-mapping interfaces, or get a custom pmac_virt_to_bus()/ >>> pmac_bus_to_virt() helper. >> >> Hmmm - I see Finn had done the DMA API conversion on macmace.c which >> might give some hints on what to do about mace.c ... no idea about >> bmac.c though. And again, haven't got hardware to test, so custom >> helpers is it, then. > > Ok.
Again, no platform specific headers to shift renamed helpers to, so may as well keep this as-is.
Cheers,
Michael
> > Arnd >
| |