lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 19/27] mips: lantiq: falcon: Fix refcount leak bug in sysctrl
    Date
    From: Liang He <windhl@126.com>

    [ Upstream commit 72a2af539fff975caadd9a4db3f99963569bd9c9 ]

    In ltq_soc_init(), of_find_compatible_node() will return a node pointer
    with refcount incremented. We should use of_node_put() when it is not
    used anymore.

    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/lantiq/falcon/sysctrl.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/arch/mips/lantiq/falcon/sysctrl.c b/arch/mips/lantiq/falcon/sysctrl.c
    index a2837a54d972..07a33bc891a9 100644
    --- a/arch/mips/lantiq/falcon/sysctrl.c
    +++ b/arch/mips/lantiq/falcon/sysctrl.c
    @@ -208,6 +208,12 @@ void __init ltq_soc_init(void)
    of_address_to_resource(np_sysgpe, 0, &res_sys[2]))
    panic("Failed to get core resources");

    + of_node_put(np_status);
    + of_node_put(np_ebu);
    + of_node_put(np_sys1);
    + of_node_put(np_syseth);
    + of_node_put(np_sysgpe);
    +
    if ((request_mem_region(res_status.start, resource_size(&res_status),
    res_status.name) < 0) ||
    (request_mem_region(res_ebu.start, resource_size(&res_ebu),
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-28 04:31    [W:4.310 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site