lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 14/27] video: fbdev: simplefb: Check before clk_put() not needed
    Date
    From: Yihao Han <hanyihao@vivo.com>

    [ Upstream commit 5491424d17bdeb7b7852a59367858251783f8398 ]

    clk_put() already checks the clk ptr using !clk and IS_ERR()
    so there is no need to check it again before calling it.

    Signed-off-by: Yihao Han <hanyihao@vivo.com>
    Reviewed-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Helge Deller <deller@gmx.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/fbdev/simplefb.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
    index 7dc0105f700d..f03705666983 100644
    --- a/drivers/video/fbdev/simplefb.c
    +++ b/drivers/video/fbdev/simplefb.c
    @@ -225,8 +225,7 @@ static int simplefb_clocks_get(struct simplefb_par *par,
    if (IS_ERR(clock)) {
    if (PTR_ERR(clock) == -EPROBE_DEFER) {
    while (--i >= 0) {
    - if (par->clks[i])
    - clk_put(par->clks[i]);
    + clk_put(par->clks[i]);
    }
    kfree(par->clks);
    return -EPROBE_DEFER;
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-28 04:31    [W:3.099 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site