lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.18 13/53] selftests: vm: Fix resource leak when return error
    Date
    From: Ding Xiang <dingxiang@cmss.chinamobile.com>

    [ Upstream commit 3084a4ec7f9bb1ec90036cfd01b1abadc5dd4fb2 ]

    When return on an error path, file handle need to be closed
    to prevent resource leak

    Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
    Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/vm/ksm_tests.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c
    index fd85f15869d1..aa834b04daa8 100644
    --- a/tools/testing/selftests/vm/ksm_tests.c
    +++ b/tools/testing/selftests/vm/ksm_tests.c
    @@ -54,6 +54,7 @@ static int ksm_write_sysfs(const char *file_path, unsigned long val)
    }
    if (fprintf(f, "%lu", val) < 0) {
    perror("fprintf");
    + fclose(f);
    return 1;
    }
    fclose(f);
    @@ -72,6 +73,7 @@ static int ksm_read_sysfs(const char *file_path, unsigned long *val)
    }
    if (fscanf(f, "%lu", val) != 1) {
    perror("fscanf");
    + fclose(f);
    return 1;
    }
    fclose(f);
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-28 04:21    [W:4.293 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site