lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v4 5/5] libata-scsi: Cap ata_device->max_sectors according to shost->max_sectors
    From
    On 6/28/22 00:25, John Garry wrote:
    > ATA devices (struct ata_device) have a max_sectors field which is
    > configured internally in libata. This is then used to (re)configure the
    > associated sdev request queue max_sectors value from how it is earlier set
    > in __scsi_init_queue(). In __scsi_init_queue() the max_sectors value is set
    > according to shost limits, which includes host DMA mapping limits.
    >
    > Cap the ata_device max_sectors according to shost->max_sectors to respect
    > this shost limit.
    >
    > Signed-off-by: John Garry <john.garry@huawei.com>
    > Acked-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

    Nit: please change the patch title to "ata: libata-scsi: Cap ..."

    > ---
    > drivers/ata/libata-scsi.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
    > index 86dbb1cdfabd..24a43d540d9f 100644
    > --- a/drivers/ata/libata-scsi.c
    > +++ b/drivers/ata/libata-scsi.c
    > @@ -1060,6 +1060,7 @@ int ata_scsi_dev_config(struct scsi_device *sdev, struct ata_device *dev)
    > dev->flags |= ATA_DFLAG_NO_UNLOAD;
    >
    > /* configure max sectors */
    > + dev->max_sectors = min(dev->max_sectors, sdev->host->max_sectors);
    > blk_queue_max_hw_sectors(q, dev->max_sectors);
    >
    > if (dev->class == ATA_DEV_ATAPI) {


    --
    Damien Le Moal
    Western Digital Research

    \
     
     \ /
      Last update: 2022-06-28 01:25    [W:4.855 / U:0.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site