Messages in this thread | | | Subject | Re: [PATCH v4] kselftests/damon: add support for cases where debugfs cannot be read | From | Shuah Khan <> | Date | Mon, 27 Jun 2022 13:46:58 -0600 |
| |
On 6/27/22 12:57 PM, SeongJae Park wrote: > From: SeongJae Park <sj@kernel.org> > > Hi Shuah, > > On Mon, 27 Jun 2022 11:00:18 -0600 Shuah Khan <skhan@linuxfoundation.org> wrote: > > [...] >>>> --- a/tools/testing/selftests/damon/_chk_dependency.sh >>>> +++ b/tools/testing/selftests/damon/_chk_dependency.sh >>>> @@ -26,3 +26,13 @@ do >>>> exit 1 >>>> fi >>>> done >>>> + >>>> +permission_error="Operation not permitted" >>>> +for f in attrs target_ids monitor_on >>>> +do >>>> + status=$( cat "$DBGFS/$f" 2>&1 ) >>>> + if [ "${status#*$permission_error}" != "$status" ]; then >>>> + echo "Permission for reading $DBGFS/$f denied; maybe secureboot enabled?" >> >> btw - does this run as a regular user or does it need root privilege? >> If so add a test for that and skip with a message. > > It needs the root permission, and does the check at the beginning[1]. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/damon/_chk_dependency.sh?h=v5.19-rc4#n9 > >
Great. Thank you. I will pull this one in for linux-kselftest next for Linux 5.20-rc1
thanks, -- Shuah
| |