Messages in this thread | | | Date | Mon, 27 Jun 2022 11:38:12 -0700 | From | Jakub Kicinski <> | Subject | Re: [PATCH] net: ethernet/nvidia: fix possible condition with no effect |
| |
On Sun, 26 Jun 2022 13:08:37 +0200 Andrew Lunn wrote: > On Sun, Jun 26, 2022 at 10:35:39AM +0000, Praghadeesh T K S wrote: > > Fix Coccinelle bug, removed condition with no effect. > > This is not a coccinelle bug. If it was, you would be patching > coccinelle, not the kernel.
I'd say the commit message is better than the commit ;) Praghadeesh, could you fix Coccinelle to avoid matching:
if (/* case 1 */) { /* BLOCK 1*/ } else (/* case 2 */ { /* BLOCK 2 */ } else { /* default == BLOCK 2 */ }
Because 99% of the time that construct is intentional.
| |