Messages in this thread | | | From | Vipin Sharma <> | Date | Mon, 27 Jun 2022 10:47:35 -0700 | Subject | Re: [PATCH] scripts/tags.sh: Include tools directory in tags generation |
| |
On Fri, Jun 17, 2022 at 5:55 PM Vipin Sharma <vipinsh@google.com> wrote: > > Add tools directory in generating tags and quiet the "No such file or > directory" warnings. > > It reverts the changes introduced in commit 162343a876f1 > ("scripts/tags.sh: exclude tools directory from tags generation") while > maintainig the original intent of the patch to get rid of the warnings. > This allows the root level cscope files to include tools source code > besides kernel and a single place to browse the code for both. > > Signed-off-by: Vipin Sharma <vipinsh@google.com> > --- > > I have found myself many times to browse tools and other part of the > kernel code together. Excluding tools from the root level cscope makes > it difficult to efficiently move between files and find user api > definitions. > > Root cause of these warning is due to generated .cmd files which use > relative paths in some files, I am not sure how to make them absolute > file paths which can satisfy realpath warnings. Also, not sure if those > warnings are helpful and should be kept. Passing "-q" to realpath seems > easier solution. Please, let me know if there is a better alternative. > > Thanks > > scripts/tags.sh | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/scripts/tags.sh b/scripts/tags.sh > index 01fab3d4f90b5..e137cf15aae9d 100755 > --- a/scripts/tags.sh > +++ b/scripts/tags.sh > @@ -25,13 +25,6 @@ else > tree=${srctree}/ > fi > > -# ignore userspace tools > -if [ -n "$COMPILED_SOURCE" ]; then > - ignore="$ignore ( -path ./tools ) -prune -o" > -else > - ignore="$ignore ( -path ${tree}tools ) -prune -o" > -fi > - > # Detect if ALLSOURCE_ARCHS is set. If not, we assume SRCARCH > if [ "${ALLSOURCE_ARCHS}" = "" ]; then > ALLSOURCE_ARCHS=${SRCARCH} > @@ -100,7 +93,7 @@ all_compiled_sources() > find $ignore -name "*.cmd" -exec \ > grep -Poh '(?(?=^source_.* \K).*|(?=^ \K\S).*(?= \\))' {} \+ | > awk '!a[$0]++' > - } | xargs realpath -es $([ -z "$KBUILD_ABS_SRCTREE" ] && echo --relative-to=.) | > + } | xargs realpath -esq $([ -z "$KBUILD_ABS_SRCTREE" ] && echo --relative-to=.) | > sort -u > } > > -- > 2.37.0.rc0.104.g0611611a94-goog >
Hi Greg,
Any update on the patch?
Thanks Vipin
| |