Messages in this thread | | | Date | Mon, 27 Jun 2022 14:44:43 -0300 | From | Ezequiel Garcia <> | Subject | Re: [PATCH v1 1/5] media: rkvdec: Disable H.264 error detection |
| |
Hi Hans,
On Fri, Jun 10, 2022 at 09:39:19AM -0700, Brian Norris wrote: > On Fri, Jun 10, 2022 at 08:52:11AM -0400, Nicolas Dufresne wrote: > > Quite often, the HW get stuck in error condition if a stream error > > was detected. As documented, the HW should stop immediately and self > > reset. There is likely a problem or a miss-understanding of the self > > self reset mechanism, as unless we make a long pause, the next command > > will then report an error even if there is no error in it. > > > > Disabling error detection fixes the issue, and let the decoder continue > > after an error. This patch is safe for backport into older kernels. > > > > Fixes: cd33c830448b ("media: rkvdec: Add the rkvdec driver") > > Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > This is effectively how ChromeOS previously was using this hardware for > years. When moving to the upstream/staging driver, this started giving > us problems. This fix is helpful; we'd rather sacrifice error detection > for now, to avoid hanging the hardware in error cases ;) > > Reviewed-by: Brian Norris <briannorris@chromium.org> > Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Given this is stable material, looks like we should queue it, while the rest of the series is still being discussed.
Thanks, Ezequiel
| |