Messages in this thread | | | Date | Mon, 27 Jun 2022 16:02:17 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v3 13/14] mei: debugfs: add pxp mode to devstate in debugfs |
| |
On Sun, Jun 19, 2022 at 04:37:20PM +0300, Alexander Usyskin wrote: > From: Tomas Winkler <tomas.winkler@intel.com> > > CC: Vitaly Lubart <vitaly.lubart@intel.com> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
We can not take patches without any changelog text, you know this :(
> --- > drivers/misc/mei/debugfs.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/drivers/misc/mei/debugfs.c b/drivers/misc/mei/debugfs.c > index 1ce61e9e24fc..4074fec866a6 100644 > --- a/drivers/misc/mei/debugfs.c > +++ b/drivers/misc/mei/debugfs.c > @@ -86,6 +86,20 @@ static int mei_dbgfs_active_show(struct seq_file *m, void *unused) > } > DEFINE_SHOW_ATTRIBUTE(mei_dbgfs_active); > > +static const char *mei_dev_pxp_mode_str(enum mei_dev_pxp_mode state) > +{ > +#define MEI_PXP_MODE(state) case MEI_DEV_PXP_##state: return #state > + switch (state) { > + MEI_PXP_MODE(DEFAULT); > + MEI_PXP_MODE(INIT); > + MEI_PXP_MODE(SETUP); > + MEI_PXP_MODE(READY);
Just spell out the case and return lines, don't create macros for no good reason please.
thanks,
greg k-h
| |