Messages in this thread | | | Date | Mon, 27 Jun 2022 14:39:31 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v1 6/9] mfd: intel_soc_pmic_crc: Drop redundant ACPI_PTR() and ifdeffery |
| |
On Mon, 27 Jun 2022, Lee Jones wrote:
> On Thu, 16 Jun 2022, Andy Shevchenko wrote: > > > The driver depends on ACPI, ACPI_PTR() resolution is always the same. > > Otherwise a compiler may produce a warning. > > > > That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or > > none should be used in a driver. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/mfd/Kconfig | 4 ++-- > > drivers/mfd/intel_soc_pmic_crc.c | 6 ++---- > > 2 files changed, 4 insertions(+), 6 deletions(-) > > Applied, thanks.
Sorry, wrong key combo - long day:
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |