Messages in this thread | | | Date | Mon, 27 Jun 2022 14:29:57 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] vt: fix memory overlapping when deleting chars in the buffer |
| |
On Mon, Jun 27, 2022 at 07:40:16PM +0800, Yangxi Xiang wrote: > > And what commit id does this fix, or has it always been broken? > > It fixes the commit 81732c3 (tty vt: Fix line garbage in virtual > console on command line edition). The line buffer is not always > broken, because the memcpy utilized the hardware acceleration, whose > result is not deterministic. I fix this issue by replacing the > scr_memcpyw with scr_memmovew used in insert_char, and preserving the > memcpy optimization when the buffers are not overlapping.
Great, can you please resend the patch with that information all in it, and the proper Fixes: line tag added?
thanks,
greg k-h
| |