lkml.org 
[lkml]   [2022]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 0/5] Add Aspeed crypto driver for hardware acceleration
Date
> Hi Neal,
>
> On 6/24/2022 2:08 AM, Neal Liu wrote:
> > Aspeed Hash and Crypto Engine (HACE) is designed to accelerate the
> > throughput of hash data digest, encryption and decryption.
> >
> > These patches aim to add Aspeed hash & crypto driver support.
> > The hash & crypto driver also pass the run-time self tests that take
> > place at algorithm registration.
> >
> > Tested-by below configs:
> > - CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set
> > - CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
> > - CONFIG_DMA_API_DEBUG=y
> > - CONFIG_DMA_API_DEBUG_SG=y
> > - CONFIG_CPU_BIG_ENDIAN=y
> >
> > Change since v3:
> > - Use dmam_alloc_coherent() instead to manage dma_alloc_coherent().
> > - Add more error handler of dma_prepare() & crypto_engine_start().
> >
> > Change since v2:
> > - Fix endianness issue. Tested on both little endian & big endian
> > system.
> > - Use common crypto hardware engine for enqueue & dequeue requests.
> > - Use pre-defined IVs for SHA-family.
> > - Revise error handler flow.
> > - Fix sorts of coding style problems.
> >
> > Change since v1:
> > - Add more error handlers, including DMA memory allocate/free, DMA
> > map/unmap, clock enable/disable, etc.
> > - Fix check dma_map error for config DMA_API_DEBUG.
> > - Fix dt-binding doc & dts node naming.
> >
> >
> > Neal Liu (5):
> > crypto: aspeed: Add HACE hash driver
> > dt-bindings: clock: Add AST2600 HACE reset definition
> > ARM: dts: aspeed: Add HACE device controller node
> > dt-bindings: crypto: add documentation for aspeed hace
> > crypto: aspeed: add HACE crypto driver
>
> The driver claims compatible with aspeed,ast2500-hace, but there's no
> equivalent g5 DTS change (patch 3/5) or reset definition (patch 2/5) in
> aspeed-clock.h? Either drop ast2500 compatible from this patch series or fix
> these.
>
> Thanks,
> Dhananjay

Okay, I miss this part. I'll fix it in next patch.
Thanks for the review.

\
 
 \ /
  Last update: 2022-06-27 04:07    [W:0.092 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site