lkml.org 
[lkml]   [2022]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] crypto: fips - make proc files report fips module name and version
    On Tue, Jun 21, 2022 at 05:08:32PM +0200, Vladis Dronov wrote:
    >
    > diff --git a/include/linux/fips.h b/include/linux/fips.h
    > index c6961e932fef..72d2e0e1d3ac 100644
    > --- a/include/linux/fips.h
    > +++ b/include/linux/fips.h
    > @@ -2,10 +2,19 @@
    > #ifndef _FIPS_H
    > #define _FIPS_H
    >
    > +#include <generated/utsrelease.h>
    > +
    > #ifdef CONFIG_CRYPTO_FIPS
    > extern int fips_enabled;
    > extern struct atomic_notifier_head fips_fail_notif_chain;
    >
    > +#define FIPS_MODULE_NAME CONFIG_CRYPTO_FIPS_NAME
    > +#ifdef CONFIG_CRYPTO_FIPS_CUSTOM_VERSION
    > +#define FIPS_MODULE_VERSION CONFIG_CRYPTO_FIPS_VERSION
    > +#else
    > +#define FIPS_MODULE_VERSION UTS_RELEASE
    > +#endif

    Why does this need to be in fips.h? If it's only used by one file
    then it should be moved to the place where it's used.

    Thanks,
    --
    Email: Herbert Xu <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

    \
     
     \ /
      Last update: 2022-06-27 03:19    [W:2.659 / U:0.656 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site