lkml.org 
[lkml]   [2022]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH RESEND v5 1/8] reset: Fix devm bulk optional exclusive control getter
From
On 6/24/22 17:18, Serge Semin wrote:
> Most likely due to copy-paste mistake the device managed version of the
> denoted reset control getter has been implemented with invalid semantic,
> which can be immediately spotted by having "WARN_ON(shared && acquired)"
> warning in the system log as soon as the method is called. Anyway let's
> fix it by altering the boolean arguments passed to the
> __devm_reset_control_bulk_get() method from
> - shared = true, optional = false, acquired = true
> to
> + shared = false, optional = true, acquired = true
> That's what they were supposed to be in the first place (see the non-devm
> version of the same method: reset_control_bulk_get_optional_exclusive()).
>
> Fixes: 48d71395896d ("reset: Add reset_control_bulk API")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
>
> ---
>
> Changelog v4:
> - This is a new patch added on v4 lap of the series.
> ---
> include/linux/reset.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/reset.h b/include/linux/reset.h
> index 8a21b5756c3e..514ddf003efc 100644
> --- a/include/linux/reset.h
> +++ b/include/linux/reset.h
> @@ -731,7 +731,7 @@ static inline int __must_check
> devm_reset_control_bulk_get_optional_exclusive(struct device *dev, int num_rstcs,
> struct reset_control_bulk_data *rstcs)
> {
> - return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, true, false, true);
> + return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, false, true, true);
> }
>
> /**

Good catch,

Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

Although, this patch should be sent as standalone since it's unrelated
to the rest of the clk patches.

--
Best regards,
Dmitry

\
 
 \ /
  Last update: 2022-06-27 00:36    [W:0.206 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site