lkml.org 
[lkml]   [2022]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] rapidio/tsi721: Replace flush_scheduled_work() with flush_work().
From
Is this change correct?

On 2022/06/12 22:31, Tetsuo Handa wrote:
> Since "struct tsi721_device" is per a device struct, I assume that
> tsi721_remove() needs to wait for only two works associated with that
> device. Therefore, wait for only these works using flush_work().
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> ---
> Changes in v2:
> Use flush_work() instead of introducing a dedicated WQ.
>
> Please see commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue()
> using a macro") for background.
>
> drivers/rapidio/devices/tsi721.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rapidio/devices/tsi721.c b/drivers/rapidio/devices/tsi721.c
> index b3134744fb55..0a42d6a2af24 100644
> --- a/drivers/rapidio/devices/tsi721.c
> +++ b/drivers/rapidio/devices/tsi721.c
> @@ -2941,7 +2941,8 @@ static void tsi721_remove(struct pci_dev *pdev)
>
> tsi721_disable_ints(priv);
> tsi721_free_irq(priv);
> - flush_scheduled_work();
> + flush_work(&priv->idb_work);
> + flush_work(&priv->pw_work);
> rio_unregister_mport(&priv->mport);
>
> tsi721_unregister_dma(priv);

\
 
 \ /
  Last update: 2022-06-26 15:58    [W:0.064 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site