Messages in this thread | | | Date | Sun, 26 Jun 2022 15:21:47 +0200 | Subject | Re: [PATCH] sh: sq: Use the bitmap API when applicable | From | Christophe JAILLET <> |
| |
Le 26/06/2022 à 12:01, Geert Uytterhoeven a écrit : > Hi Christophe, > > On Sat, Jun 25, 2022 at 9:45 AM Christophe JAILLET > <christophe.jaillet@wanadoo.fr> wrote: >> Using the bitmap API is less verbose than hand writing them. >> It also improves the semantic. > > Thanks for your patch! > >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> >> --- >> I don't cross compile, so this patch is NOT compile-tested. > > Why not?
The main reason is:
df /dev/sdc3 ... 98% /
> Cross-compiling is so easy nowadays? > Many distros even provide cross-compilers ("apt install gcc-sh4-linux-gnu"). > Else try https://mirrors.edge.kernel.org/pub/tools/crosstool/. > >> --- a/arch/sh/kernel/cpu/sh4/sq.c >> +++ b/arch/sh/kernel/cpu/sh4/sq.c > >> @@ -382,7 +381,7 @@ static int __init sq_api_init(void) >> if (unlikely(!sq_cache)) >> return ret; >> >> - sq_bitmap = kzalloc(size, GFP_KERNEL); >> + sq_bitmap = bitmap_zalloc(nr_pages, GFP_KERNEL); > > Perhaps you need #include <linux/bitmap.h>?
or not. See [1].
> > I don't know, I also didn't bother to cross-compile. Why would I? ;-)
I'll refrain from posting things that I can't compile-test myself in the future.
Sorry for the noise, please just ignore the patch, it was just a clean-up anyway.
CJ
[1]: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/sh/kernel/cpu/sh4/sq.c#n12
> > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >
| |