lkml.org 
[lkml]   [2022]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/36] serial: Add uart_rs485_config()
    From
    Date
    On 25.06.22 at 22:19, Lukas Wunner wrote:

    >
    > Why doesn't this helper acquire the port spinlock, unlike
    > uart_set_rs485_config()? Is this safe? Do all callers hold the lock?
    > Do we need an assertion to verify the lock is held?
    >

    AFAIU the callers are using this only during initialization, so there is nothing else
    at this time that accesses the serial_rs485 struct and thus no need for locking.

    Regards,
    Lino

    \
     
     \ /
      Last update: 2022-06-26 14:38    [W:3.651 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site