lkml.org 
[lkml]   [2022]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/8] ksmbd: use vfs_llseek instead of dereferencing NULL
I just added it to ksmbd-for-next

Thx.

On Sat, Jun 25, 2022 at 5:20 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> Hi Steve,
>
> On Sat, Jun 25, 2022 at 01:01:08PM +0200, Jason A. Donenfeld wrote:
> > By not checking whether llseek is NULL, this might jump to NULL. Also,
> > it doesn't check FMODE_LSEEK. Fix this by using vfs_llseek(), which
> > always does the right thing.
> >
> > Fixes: f44158485826 ("cifsd: add file operations")
> > Cc: stable@vger.kernel.org
> > Cc: linux-cifs@vger.kernel.org
> > Cc: Steve French <stfrench@microsoft.com>
> > Cc: Ronnie Sahlberg <lsahlber@redhat.com>
> > Cc: Hyunchul Lee <hyc.lee@gmail.com>
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Reviewed-by: Namjae Jeon <linkinjeon@kernel.org>
> > Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
>
> This commit has been reviewed by Namjae and acked by Al. The rest of the
> commits in this series are likely -next material for Al to take in his
> vfs tree, but this first one here is something you might consider taking
> as a somewhat important bug fix for 5.19. I marked it for stable@ and
> such as well. Your call -- you can punt it to Al's -next branch with the
> rest of the series if you want -- but I think this patch is a bit unlike
> the others. This occurred to me when I saw you sent some cifs fixes in
> earlier this evening.
>
> Jason



--
Thanks,

Steve

\
 
 \ /
  Last update: 2022-06-26 02:56    [W:0.042 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site