Messages in this thread | | | Date | Sat, 25 Jun 2022 09:17:31 +0200 | From | Lukas Wunner <> | Subject | Re: [PATCH net-next v1 1/1] net: phy: ax88772a: fix lost pause advertisement configuration |
| |
On Fri, Jun 24, 2022 at 09:55:58AM +0200, Oleksij Rempel wrote: > In case of asix_ax88772a_link_change_notify() workaround, we run soft > reset which will automatically clear MII_ADVERTISE configuration. The > PHYlib framework do not know about changed configuration state of the > PHY, so we need to save and restore all needed configuration registers. [...] > static void asix_ax88772a_link_change_notify(struct phy_device *phydev) > { > /* Reset PHY, otherwise MII_LPA will provide outdated information. > * This issue is reproducible only with some link partner PHYs > */ > - if (phydev->state == PHY_NOLINK && phydev->drv->soft_reset) > + if (phydev->state == PHY_NOLINK && phydev->drv->soft_reset) { > + struct asix_context context; > + > + asix_context_save(phydev, &context); > + > phydev->drv->soft_reset(phydev); > + > + asix_context_restore(phydev, &context); > + } > }
Hm, how about just calling phy_init_hw()? That will perform a ->soft_reset() and also restore the configuration, including interrupts (which the above does not, but I guess that's irrelevant as long as the driver uses polling).
Does phy_init_hw() do too much or too little compared to the above and is hence not a viable solution?
Thanks,
Lukas
| |