lkml.org 
[lkml]   [2022]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/3] mfd: intel-m10-bmc: rename the local variables
From
Date

On 6/24/22 2:22 AM, Tianfei Zhang wrote:
> It had better use ddata for local variables which
> directly interacts with dev_get_drvdata()/dev_set_drvdata().

This is a cleanup, not related to the patchset, it should be split from
the patchset.

Tom

>
> Signed-off-by: Tianfei Zhang <tianfei.zhang@intel.com>
> ---
> drivers/mfd/intel-m10-bmc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/intel-m10-bmc.c b/drivers/mfd/intel-m10-bmc.c
> index 8db3bcf5fccc..7e521df29c72 100644
> --- a/drivers/mfd/intel-m10-bmc.c
> +++ b/drivers/mfd/intel-m10-bmc.c
> @@ -86,15 +86,15 @@ static DEVICE_ATTR_RO(bmcfw_version);
> static ssize_t mac_address_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> - struct intel_m10bmc *max10 = dev_get_drvdata(dev);
> + struct intel_m10bmc *ddata = dev_get_drvdata(dev);
> unsigned int macaddr_low, macaddr_high;
> int ret;
>
> - ret = m10bmc_sys_read(max10, M10BMC_MAC_LOW, &macaddr_low);
> + ret = m10bmc_sys_read(ddata, M10BMC_MAC_LOW, &macaddr_low);
> if (ret)
> return ret;
>
> - ret = m10bmc_sys_read(max10, M10BMC_MAC_HIGH, &macaddr_high);
> + ret = m10bmc_sys_read(ddata, M10BMC_MAC_HIGH, &macaddr_high);
> if (ret)
> return ret;
>
> @@ -111,11 +111,11 @@ static DEVICE_ATTR_RO(mac_address);
> static ssize_t mac_count_show(struct device *dev,
> struct device_attribute *attr, char *buf)
> {
> - struct intel_m10bmc *max10 = dev_get_drvdata(dev);
> + struct intel_m10bmc *ddata = dev_get_drvdata(dev);
> unsigned int macaddr_high;
> int ret;
>
> - ret = m10bmc_sys_read(max10, M10BMC_MAC_HIGH, &macaddr_high);
> + ret = m10bmc_sys_read(ddata, M10BMC_MAC_HIGH, &macaddr_high);
> if (ret)
> return ret;
>

\
 
 \ /
  Last update: 2022-06-25 15:30    [W:0.473 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site