Messages in this thread | | | Date | Sat, 25 Jun 2022 14:29:09 +0100 | From | Al Viro <> | Subject | Re: [PATCH v2 3/8] fs: clear or set FMODE_LSEEK based on llseek function |
| |
On Sat, Jun 25, 2022 at 06:07:45AM -0700, Christoph Hellwig wrote: > On Sat, Jun 25, 2022 at 01:01:10PM +0200, Jason A. Donenfeld wrote: > > This helps unify a longstanding wart where FMODE_LSEEK hasn't been > > uniformly unset when it should be. > > I think we could just remove FMODE_LSEEK after the previous patch > as we can just check for the presence of a ->llseek method instead.
I wouldn't bet on that - as it is, an ->open() instance can decide in some cases to clear FMODE_LSEEK, despite having file_operations with non-NULL ->llseek.
| |