lkml.org 
[lkml]   [2022]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/8] fs: remove no_llseek
On Sat, Jun 25, 2022 at 01:01:13PM +0200, Jason A. Donenfeld wrote:
> Now that all callers of ->llseek are going through vfs_llseek(), we
> don't gain anything by keeping no_llseek around. Nothing compares it or
> calls it.

Shouldn't this and the checks for no_llseek simply be merged into patch
2?

> + if ((file->f_mode & FMODE_LSEEK) && file->f_op->llseek)
> + return file->f_op->llseek(file, offset, whence);
> + return -ESPIPE;

No function change, but in general checking for the error condition
in the branch tends to be more readable. i.e.:

if (!(file->f_mode & FMODE_LSEEK) || !file->f_op->llseek)
return -ESPIPE;
return file->f_op->llseek(file, offset, whence);

\
 
 \ /
  Last update: 2022-06-25 15:10    [W:1.673 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site