lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] brcmfmac: Remove #ifdef guards for PM related functions
From
On 6/24/2022 11:32 AM, Paul Cercueil wrote:
> Hi,
>
> Le ven., juin 24 2022 at 09:31:22 -0700, Jeff Johnson
> <quic_jjohnson@quicinc.com> a écrit :
>> On 6/24/2022 2:24 AM, Arend Van Spriel wrote:
>>> On 6/23/2022 2:42 PM, Paul Cercueil wrote:
>>
>> [snip]
>>
>>>> -    if (sdiodev->freezer) {
>>>> +    if (IS_ENABLED(CONFIG_PM_SLEEP) && sdiodev->freezer) {
>>>
>>> This change is not necessary. sdiodev->freezer will be NULL when
>>> CONFIG_PM_SLEEP is not enabled.
>>
>> but won't the compiler be able to completely optimize the code away if
>> the change is present?
>
> That's correct. But do we want to complexify a bit the code for the sake
> of saving a few bytes? I leave that as an open question to the
> maintainer, I'm really fine with both options.

I'm fine either way as well. I'd have stronger opinions if ath drivers
were involved ;)

\
 
 \ /
  Last update: 2022-06-24 21:00    [W:0.034 / U:2.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site