Messages in this thread | | | Date | Fri, 24 Jun 2022 11:31:30 -0700 | From | Matthias Kaehlcke <> | Subject | Re: [PATCH v1 1/2] PCI: qcom: Add system PM support |
| |
On Fri, Jun 24, 2022 at 12:58:01PM +0530, Krishna chaitanya chundru wrote: > Add suspend and resume pm callbacks. > > When system suspends, and if the link is in L1ss, disable the clocks > so that system enters into low power state to save the maximum power. > And when the system resumes, enable the clocks back if they are > disabled in the suspend path. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
On which tree is this series based on?
With v5.19-rc3 I get:
CC drivers/pci/controller/dwc/pcie-qcom.o /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:1658:26: error: cannot assign to non-static data member 'cfg' with const-qualified type 'const struct qcom_pcie_cfg *' pcie->cfg->is_suspended = false; ~~~~~~~~~~~~~~~~~~~~~~~ ^ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:218:30: note: non-static data member 'cfg' declared const here const struct qcom_pcie_cfg *cfg; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:1721:2: error: use of undeclared identifier 'val' val = readl(pcie->parf + PCIE20_PARF_PM_STTS); ^ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:1722:8: error: use of undeclared identifier 'val' if (!(val & PCIE20_PARF_PM_STTS_LINKST_IN_L1SUB)) { ^ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:1733:26: error: cannot assign to non-static data member 'cfg' with const-qualified type 'const struct qcom_pcie_cfg *' pcie->cfg->is_suspended = true; ~~~~~~~~~~~~~~~~~~~~~~~ ^ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:218:30: note: non-static data member 'cfg' declared const here const struct qcom_pcie_cfg *cfg; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:1749:9: error: no member named 'ops' in 'struct qcom_pcie' pcie->ops->enable_clks(pcie); ~~~~ ^ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:1752:9: error: no member named 'ops' in 'struct qcom_pcie' pcie->ops->post_init(pcie); ~~~~ ^ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:1754:26: error: cannot assign to non-static data member 'cfg' with const-qualified type 'const struct qcom_pcie_cfg *' pcie->cfg->is_suspended = false; ~~~~~~~~~~~~~~~~~~~~~~~ ^ /mnt/host/source/src/third_party/kernel/v5.15/drivers/pci/controller/dwc/pcie-qcom.c:218:30: note: non-static data member 'cfg' declared const here const struct qcom_pcie_cfg *cfg; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ 7 errors generated.
| |