lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    Subject[PATCH 2/3] KVM: x86/mmu: Use "unsigned int", not "u32", for SPTEs' @access info
    From
    Use an "unsigned int" for @access parameters instead of a "u32", mostly
    to be consistent throughout KVM, but also because "u32" is misleading.
    @access can actually squeeze into a u8, i.e. doesn't need 32 bits, but is
    as an "unsigned int" because sp->role.access is an unsigned int.

    No functional change intended.

    Link: https://lore.kernel.org/all/YqyZxEfxXLsHGoZ%2F@google.com
    Cc: David Matlack <dmatlack@google.com>
    Signed-off-by: Sean Christopherson <seanjc@google.com>
    ---
    arch/x86/kvm/mmu/mmu.c | 10 ++++++----
    1 file changed, 6 insertions(+), 4 deletions(-)

    diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
    index 07dfed427d5b..e2213eeadebc 100644
    --- a/arch/x86/kvm/mmu/mmu.c
    +++ b/arch/x86/kvm/mmu/mmu.c
    @@ -717,7 +717,8 @@ static u32 kvm_mmu_page_get_access(struct kvm_mmu_page *sp, int index)
    return sp->role.access;
    }

    -static void kvm_mmu_page_set_translation(struct kvm_mmu_page *sp, int index, gfn_t gfn, u32 access)
    +static void kvm_mmu_page_set_translation(struct kvm_mmu_page *sp, int index,
    + gfn_t gfn, unsigned int access)
    {
    if (sp_has_gptes(sp)) {
    sp->shadowed_translation[index] = (gfn << PAGE_SHIFT) | access;
    @@ -735,7 +736,8 @@ static void kvm_mmu_page_set_translation(struct kvm_mmu_page *sp, int index, gfn
    sp->gfn, kvm_mmu_page_get_gfn(sp, index), gfn);
    }

    -static void kvm_mmu_page_set_access(struct kvm_mmu_page *sp, int index, u32 access)
    +static void kvm_mmu_page_set_access(struct kvm_mmu_page *sp, int index,
    + unsigned int access)
    {
    gfn_t gfn = kvm_mmu_page_get_gfn(sp, index);

    @@ -1580,7 +1582,7 @@ static bool kvm_test_age_rmapp(struct kvm *kvm, struct kvm_rmap_head *rmap_head,
    static void __rmap_add(struct kvm *kvm,
    struct kvm_mmu_memory_cache *cache,
    const struct kvm_memory_slot *slot,
    - u64 *spte, gfn_t gfn, u32 access)
    + u64 *spte, gfn_t gfn, unsigned int access)
    {
    struct kvm_mmu_page *sp;
    struct kvm_rmap_head *rmap_head;
    @@ -1601,7 +1603,7 @@ static void __rmap_add(struct kvm *kvm,
    }

    static void rmap_add(struct kvm_vcpu *vcpu, const struct kvm_memory_slot *slot,
    - u64 *spte, gfn_t gfn, u32 access)
    + u64 *spte, gfn_t gfn, unsigned int access)
    {
    struct kvm_mmu_memory_cache *cache = &vcpu->arch.mmu_pte_list_desc_cache;

    --
    2.37.0.rc0.161.g10f37bed90-goog
    \
     
     \ /
      Last update: 2022-06-24 19:19    [W:3.420 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site