lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/6] fs: clear FMODE_LSEEK if no llseek function
Hi Al,

On Fri, Jun 24, 2022 at 06:04:19PM +0100, Al Viro wrote:
> On Fri, Jun 24, 2022 at 06:56:28PM +0200, Jason A. Donenfeld wrote:
> > This helps unify a longstanding wart where FMODE_LSEEK hasn't been
> > uniformly unset when it should be.
> >
> > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> > ---
> > fs/file_table.c | 2 ++
> > fs/open.c | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/fs/file_table.c b/fs/file_table.c
> > index 5424e3a8df5f..15700b2e1b53 100644
> > --- a/fs/file_table.c
> > +++ b/fs/file_table.c
> > @@ -241,6 +241,8 @@ static struct file *alloc_file(const struct path *path, int flags,
> > if ((file->f_mode & FMODE_WRITE) &&
> > likely(fop->write || fop->write_iter))
> > file->f_mode |= FMODE_CAN_WRITE;
> > + if ((file->f_mode & FMODE_LSEEK) && !file->f_op->llseek)
> > + file->f_mode &= ~FMODE_LSEEK;
>
> Where would FMODE_LSEEK come from in this one? ->f_mode is set
> (in __alloc_file()) to OPEN_FMODE(flags); that does deal with FMODE_READ
> and FMODE_WRITE, but FMODE_LSEEK will be clear...

From the `int flags` parameter of the function. That's an O flag not an
F flag, though, so I assume you mean that it's impossible to get LSEEK
there in practice? If so, I'll drop this hunk.

Jason

\
 
 \ /
  Last update: 2022-06-24 19:10    [W:0.039 / U:3.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site