Messages in this thread | | | Date | Fri, 24 Jun 2022 12:06:41 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v3 2/2] PCI: qcom: move register accesses to .post_init |
| |
On Fri, Jun 24, 2022 at 12:46:55PM +0200, Robert Marko wrote: > On Fri, 24 Jun 2022 at 12:36, Robert Marko <robimarko@gmail.com> wrote: > > On Thu, 23 Jun 2022 at 23:55, Bjorn Helgaas <helgaas@kernel.org> wrote: > > > On Thu, Jun 23, 2022 at 05:50:04PM +0200, Robert Marko wrote: > > > > Move register accesses from .init to .post_init callbacks to maintain > > > > consinstency for all IP since IPQ8074 specifically requires PHY-s to be > > > > powered on before register access and its accesses have been moved to > > > > .post_init. > > > > > > This doesn't do the corresponding move for qcom_pcie_init_2_7_0(). Is > > > that intentional or an oversight? > > > > Hi, > > > > It was an oversight on my part, will fixup it now, sorry for the mistake. > > > > Regards, > > Robert > > Bjorn, > > I updated the title and description based on your fixups in your branch, > hope that is ok.
It's great, thanks for noticing and paying attention to the little details!
Bjorn
| |