lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/4] clk: qcom: sc7280: Update clk_init_data to const for GCC
On Wed 02 Feb 10:35 PST 2022, Taniya Das wrote:

> Update clk_init_data to const and also use index instead of fw_name for
> global clock controller.
>
> Fixes: a3cc092196ef6 ("clk: qcom: Add Global Clock controller (GCC) driver for SC7280")
> Signed-off-by: Taniya Das <tdas@codeaurora.org>

Hi Taniya,

I'm not able to find a new revision of this series in the inbox, could
you please respin it?

> ---
> drivers/clk/qcom/gcc-sc7280.c | 362 +++++++++++++++++-----------------
> 1 file changed, 181 insertions(+), 181 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-sc7280.c b/drivers/clk/qcom/gcc-sc7280.c
> index 423627d49719..ccecd3d8a6d9 100644
> --- a/drivers/clk/qcom/gcc-sc7280.c
> +++ b/drivers/clk/qcom/gcc-sc7280.c
> @@ -1,6 +1,6 @@
> // SPDX-License-Identifier: GPL-2.0-only
> /*
> - * Copyright (c) 2020-2021, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2020-2022, The Linux Foundation. All rights reserved.
> */
>
> #include <linux/clk-provider.h>
> @@ -45,10 +45,10 @@ static struct clk_alpha_pll gcc_gpll0 = {
> .clkr = {
> .enable_reg = 0x52010,
> .enable_mask = BIT(0),
> - .hw.init = &(struct clk_init_data){
> + .hw.init = &(const struct clk_init_data){

And while doing so, please split this into one patch adding the const...

> .name = "gcc_gpll0",
> .parent_data = &(const struct clk_parent_data){
> - .fw_name = "bi_tcxo",
> + .index = 0,

and a separate patch changing fw_name to index. If there are regressions
we want to be able to bisect it down to the right one.

Also, please add a define for BI_TCXO, instead of having a comment in
most places - like I did in gcc-sc8280xp.c (but as we have existing dts
I don't think it's wise to replace all fw_name entries with .index)..

Thanks,
Bjorn

\
 
 \ /
  Last update: 2022-06-24 19:08    [W:0.047 / U:1.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site