| Date | Fri, 24 Jun 2022 18:08:15 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v3 19/40] arm64: dts: tegra: align gpio-key node names with dtschema |
| |
On Wed, Jun 15, 2022 at 05:53:12PM -0700, Krzysztof Kozlowski wrote: [...] > diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts > index f16acb4cabaa..62d58221ad3c 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts > +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts > @@ -1030,7 +1030,7 @@ clk32k_in: clock-32k { > gpio-keys { > compatible = "gpio-keys"; > > - lid { > + switch-lid { > label = "Lid"; > gpios = <&gpio TEGRA_GPIO(R, 4) GPIO_ACTIVE_LOW>; > linux,input-type = <5>; > @@ -1039,7 +1039,7 @@ lid { > wakeup-source; > }; > > - power { > + switch-power {
This one is actually a key.
[...] > diff --git a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts > index a263d51882ee..8494c7b2961b 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts > +++ b/arch/arm64/boot/dts/nvidia/tegra210-smaug.dts [...] > @@ -1772,7 +1772,7 @@ lid { > wakeup-source; > }; > > - tablet_mode { > + key-tablet-mode { > label = "Tablet Mode"; > gpios = <&gpio TEGRA_GPIO(Z, 2) GPIO_ACTIVE_HIGH>; > linux,input-type = <EV_SW>;
And this one more like a switch since it's triggered by a magnet, as far as I understand.
No need to resend, I can fix these up when I apply. Just let me know if you have any objections to me making those changes.
Thierry [unhandled content-type:application/pgp-signature] |