lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm: fix device_node_continue.cocci warnings (fwd)
Hi,

On Fri 24 Jun 22, 17:08, Paul Kocialkowski wrote:
> Hi Julia,
>
> On Sun 12 Jun 22, 13:02, Julia Lawall wrote:
> > The of_node_put does not seem to be needed. Note that there is none at
> > the preceeding continues.
>
> That looks like a correct fix, thanks!

Pushed to drm-misc-next, thanks!

Paul

> > julia
> >
> > ---------- Forwarded message ----------
> > Date: Sat, 11 Jun 2022 06:02:45 +0800
> > From: kernel test robot <lkp@intel.com>
> > To: kbuild@lists.01.org
> > Cc: lkp@intel.com, Julia Lawall <julia.lawall@lip6.fr>
> > Subject: [PATCH] drm: fix device_node_continue.cocci warnings
> >
> > CC: kbuild-all@lists.01.org
> > BCC: lkp@intel.com
> > CC: Linux Memory Management List <linux-mm@kvack.org>
> > TO: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > CC: Maxime Ripard <mripard@kernel.org>
> > CC: David Airlie <airlied@linux.ie>
> > CC: Daniel Vetter <daniel@ffwll.ch>
> > CC: dri-devel@lists.freedesktop.org
> > CC: linux-kernel@vger.kernel.org
> >
> > From: kernel test robot <lkp@intel.com>
> >
> > drivers/gpu/drm/logicvc/logicvc_layer.c:616:2-13: ERROR: probable double put.
> >
> > Device node iterators put the previous value of the index variable, so an
> > explicit put causes a double put.
> >
> > Generated by: scripts/coccinelle/iterators/device_node_continue.cocci
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > ---
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: 6d0c806803170f120f8cb97b321de7bd89d3a791
> > commit: efeeaefe9be56e8ae5e5b4e9ff6d2275ec977ec5 [2027/2566] drm: Add support for the LogiCVC display controller
> > :::::: branch date: 17 hours ago
> > :::::: commit date: 31 hours ago
> >
> > Please take the patch only if it's a positive warning. Thanks!
> >
> > drivers/gpu/drm/logicvc/logicvc_layer.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> > +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> > @@ -612,8 +612,6 @@ int logicvc_layers_init(struct logicvc_d
> > ret = logicvc_layer_init(logicvc, layer_node, index);
> > if (ret)
> > goto error;
> > -
> > - of_node_put(layer_node);
> > }
> >
> > of_node_put(layers_node);
>
> --
> Paul Kocialkowski, Bootlin
> Embedded Linux and kernel engineering
> https://bootlin.com



--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-24 17:28    [W:0.080 / U:1.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site