lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RESEND v4 07/15] PCI: tegra194: Drop manual DW PCIe controller version setup
    Date
    Since the DW PCIe common code now supports the IP-core version
    auto-detection there is no point in manually setting the version up for the
    controllers newer than v4.70a. Seeing Tegra 194 PCIe Host and EP
    controllers are based on the DW PCIe v4.90a IP-core we can freely drop the
    dw_pcie.version field initialization.

    Suggested-by: Rob Herring <robh@kernel.org>
    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

    ---

    Folks, I don't have Tegra 194 PCIe hw instance to test it out. Could you
    please make sure this patch doesn't brake anything?

    Changelog v3:
    - This is a new patch create as a result of the discussion:
    https://lore.kernel.org/linux-pci/20220503214638.1895-6-Sergey.Semin@baikalelectronics.ru/
    ---
    drivers/pci/controller/dwc/pcie-tegra194.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
    index f24b30b7454f..e497e6de8d15 100644
    --- a/drivers/pci/controller/dwc/pcie-tegra194.c
    +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
    @@ -1979,7 +1979,6 @@ static int tegra194_pcie_probe(struct platform_device *pdev)
    pci->ops = &tegra_dw_pcie_ops;
    pci->n_fts[0] = N_FTS_VAL;
    pci->n_fts[1] = FTS_VAL;
    - pci->version = DW_PCIE_VER_490A;

    pp = &pci->pp;
    pp->num_vectors = MAX_MSI_IRQS;
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-24 16:41    [W:4.093 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site