lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RESEND v5 08/18] PCI: dwc: Add trailing new-line literals to the log messages
    Date
    There are two places in the DW PCIe controller driver, which omit the
    trailing newlines in the log info and warn messages. Not having them there
    will cause leaving the messages in the printk ring buffer until a next
    '\n'-terminated message is printed (it will consequently cause the buffer
    flush). As it isn't what the corresponding code implies let's add the
    new-line characters in the messages.

    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
    Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
    Reviewed-by: Rob Herring <robh@kernel.org>
    ---
    drivers/pci/controller/dwc/pcie-designware-host.c | 2 +-
    drivers/pci/controller/dwc/pcie-designware.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
    index d4326aae5a32..9a4922b714e5 100644
    --- a/drivers/pci/controller/dwc/pcie-designware-host.c
    +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
    @@ -633,7 +633,7 @@ void dw_pcie_setup_rc(struct pcie_port *pp)
    }

    if (pci->num_ob_windows <= atu_idx)
    - dev_warn(pci->dev, "Resources exceed number of ATU entries (%d)",
    + dev_warn(pci->dev, "Resources exceed number of ATU entries (%d)\n",
    pci->num_ob_windows);
    }

    diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
    index d0061735b434..ac966ed28c5b 100644
    --- a/drivers/pci/controller/dwc/pcie-designware.c
    +++ b/drivers/pci/controller/dwc/pcie-designware.c
    @@ -706,7 +706,7 @@ void dw_pcie_iatu_detect(struct dw_pcie *pci)
    dev_info(pci->dev, "iATU unroll: %s\n", pci->iatu_unroll_enabled ?
    "enabled" : "disabled");

    - dev_info(pci->dev, "Detected iATU regions: %u outbound, %u inbound",
    + dev_info(pci->dev, "Detected iATU regions: %u outbound, %u inbound\n",
    pci->num_ob_windows, pci->num_ib_windows);
    }

    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-24 16:36    [W:3.964 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site