Messages in this thread | | | Date | Fri, 24 Jun 2022 11:14:09 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH 1/2] vfio/type1: Simplify bus_type determination |
| |
On Tue, Jun 21, 2022 at 08:09:20PM +0100, Robin Murphy wrote:
> Quick consensus then: does anyone have a particular preference between > changing the .attach_group signature vs. adding a helper based on > vfio_group_get_from_iommu() for type1 to call from within its callback? They > seem about equal (but opposite) in terms of the simplicity vs. impact > tradeoff to me, so I can't quite decide conclusively...
Ah, I've been away and only just saw this..
Given Alex's remarks and the need to re-get the vfio_group in the helper, it may be very slightly nicer to pass in the vfio_device as an argument. But either works for me.
Jason
| |