lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/10] iio: adc: mcp3911: add support for oversampling ratio
On Thu, Jun 23, 2022 at 09:20:01PM +0200, Andy Shevchenko wrote:
> On Thu, Jun 23, 2022 at 9:08 PM Marcus Folkesson
> <marcus.folkesson@gmail.com> wrote:
> >
> > The chip support oversampling ratio so expose it to userspace.
>
> supports
>
> ratio, so
>
> ...

Thanks
>
> > +static const int mcp3911_osr_table[] = {32, 64, 128, 256, 512, 1024, 2048, 4096};
>
> Spaces inside {}.

Not sure what you mean?
>
> ...
>
> > }
> >
> > +
>
> Unwanted blank line.
>
> ...

Removed
>
> > + switch (val) {
> > + case 4096:
> > + val = FIELD_PREP(MCP3911_CONFIG_OSR, 0x07);
> > + break;
> > + case 2048:
> > + val = FIELD_PREP(MCP3911_CONFIG_OSR, 0x06);
> > + break;
> > + case 1024:
> > + val = FIELD_PREP(MCP3911_CONFIG_OSR, 0x05);
> > + break;
> > + case 512:
> > + val = FIELD_PREP(MCP3911_CONFIG_OSR, 0x04);
> > + break;
> > + case 256:
> > + val = FIELD_PREP(MCP3911_CONFIG_OSR, 0x03);
> > + break;
> > + case 128:
> > + val = FIELD_PREP(MCP3911_CONFIG_OSR, 0x02);
> > + break;
> > + case 64:
> > + val = FIELD_PREP(MCP3911_CONFIG_OSR, 0x01);
> > + break;
> > + case 32:
> > + val = FIELD_PREP(MCP3911_CONFIG_OSR, 0x00);
> > + break;
> > + default:
> > + ret = -EINVAL;
> > + goto out;
> > + }
>
> I understood why the table above, but this is a waste of resources.
> Use that table

Yep, I will use the table instead
>
> ...
>
> > + ret = mcp3911_update(adc, MCP3911_REG_CONFIG,
> > + MCP3911_CONFIG_OSR,
> > + val, 2);
>
> sizeof() ?

sizeof() what?


Thanks,
Marcus Folkesson
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-24 14:08    [W:0.062 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site