lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] crypto: ccp - During shutdown, check SEV data pointer before using
On Thu, Jun 16, 2022 at 10:26:18AM -0500, Tom Lendacky wrote:
> On shutdown, each CCP device instance performs shutdown processing.
> However, __sev_platform_shutdown_locked() uses the controlling psp
> structure to obtain the pointer to the sev_device structure. However,
> during driver initialization, it is possible that an error can be received
> from the firmware that results in the sev_data pointer being cleared from
> the controlling psp structure. The __sev_platform_shutdown_locked()
> function does not check for this situation and will segfault.
>
> While not common, this scenario should be accounted for. Add a check for a
> NULL sev_device structure before attempting to use it.
>
> Fixes: 5441a07a127f ("crypto: ccp - shutdown SEV firmware on kexec")
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> drivers/crypto/ccp/sev-dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2022-06-24 11:15    [W:0.090 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site