lkml.org 
[lkml]   [2022]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH RESEND v2 2/2] bus: bt1-axi: Don't print error on -EPROBE_DEFER
    Date
    The Baikal-T1 AXI bus driver correctly handles the deferred probe
    situation, but still pollutes the system log with a misleading error
    message. Let's fix that by using the dev_err_probe() method to print the
    log message in case of the clocks/resets request errors.

    Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

    ---

    Link: https://lore.kernel.org/lkml/20220610080103.10689-1-Sergey.Semin@baikalelectronics.ru/
    Changelog v2:
    - Use the dev_err_probe() return value as the return status of the
    corresponding method. (@Philipp)

    Link: https://lore.kernel.org/lkml/20220610104030.28399-2-Sergey.Semin@baikalelectronics.ru/
    Changelog v3:
    - Just resend.
    - Rebase onto the kernel v5.19-rcX.
    ---
    drivers/bus/bt1-axi.c | 14 ++++++--------
    1 file changed, 6 insertions(+), 8 deletions(-)

    diff --git a/drivers/bus/bt1-axi.c b/drivers/bus/bt1-axi.c
    index e7a6744acc7b..70e49a6e5374 100644
    --- a/drivers/bus/bt1-axi.c
    +++ b/drivers/bus/bt1-axi.c
    @@ -135,10 +135,9 @@ static int bt1_axi_request_rst(struct bt1_axi *axi)
    int ret;

    axi->arst = devm_reset_control_get_optional_exclusive(axi->dev, "arst");
    - if (IS_ERR(axi->arst)) {
    - dev_warn(axi->dev, "Couldn't get reset control line\n");
    - return PTR_ERR(axi->arst);
    - }
    + if (IS_ERR(axi->arst))
    + return dev_err_probe(axi->dev, PTR_ERR(axi->arst),
    + "Couldn't get reset control line\n");

    ret = reset_control_deassert(axi->arst);
    if (ret)
    @@ -159,10 +158,9 @@ static int bt1_axi_request_clk(struct bt1_axi *axi)
    int ret;

    axi->aclk = devm_clk_get(axi->dev, "aclk");
    - if (IS_ERR(axi->aclk)) {
    - dev_err(axi->dev, "Couldn't get AXI Interconnect clock\n");
    - return PTR_ERR(axi->aclk);
    - }
    + if (IS_ERR(axi->aclk))
    + return dev_err_probe(axi->dev, PTR_ERR(axi->aclk),
    + "Couldn't get AXI Interconnect clock\n");

    ret = clk_prepare_enable(axi->aclk);
    if (ret) {
    --
    2.35.1
    \
     
     \ /
      Last update: 2022-06-24 23:11    [W:2.747 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site