Messages in this thread | | | Date | Fri, 24 Jun 2022 23:05:25 +0200 | From | Stephen Kitt <> | Subject | Re: [PATCH] rtc: use simple i2c probe |
| |
On Fri, 24 Jun 2022 19:42:49 +0200, Alexandre Belloni <alexandre.belloni@bootlin.com> wrote: > On 12/06/2022 21:23:47+0200, Stephen Kitt wrote: > > Do you have an example of a change requiring id to support RTCs on x86 > > systems? > > I checked and your patch is actually fine, the issue I referred to is: > > 1c1b3098ae1e ("rtc: pcf85063: add i2c_device_id name matching support")
Ah yes, I see! The changes I’m making are compatible with that (as you figured out), I’m not removing the id tables, just avoiding calls to i2c_match_id when they’re not needed. In fact the approach I use for drivers which do need their id tables is the same as in the commit above, with an explicit call to i2c_match_id instead of the old-style probe.
Regards,
Stephen [unhandled content-type:application/pgp-signature] | |