Messages in this thread | | | Date | Fri, 24 Jun 2022 21:38:59 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH v2 3/3] drm/panel: sony-acx565akm: Use backlight helpers |
| |
On Thu, Jun 16, 2022 at 07:23:15PM +0200, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Instead of manually checking the power state in struct > backlight_properties, use backlight_is_blank(). > > While we're at it, drop .fb_blank from the initialisation function; it > is deprecated, and this helps make progress towards enabling its > removal. This change makes no functional difference since > FB_BLANK_UNBLANK is the default value. > > Signed-off-by: Stephen Kitt <steve@sk2.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: dri-devel@lists.freedesktop.org Thanks, applied to drm-misc (drm-misc-next)
Sam
| |