lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 016/264] random: fix warning message on ia64 and parisc
    Date
    From: Helge Deller <deller@gmx.de>

    commit 51d96dc2e2dc2cf9b81cf976cc93c51ba3ac2f92 upstream.

    Fix the warning message on the parisc and IA64 architectures to show the
    correct function name of the caller by using %pS instead of %pF. The
    message is printed with the value of _RET_IP_ which calls
    __builtin_return_address(0) and as such returns the IP address caller
    instead of pointer to a function descriptor of the caller.

    The effect of this patch is visible on the parisc and ia64 architectures
    only since those are the ones which use function descriptors while on
    all others %pS and %pF will behave the same.

    Cc: Theodore Ts'o <tytso@mit.edu>
    Cc: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Helge Deller <deller@gmx.de>
    Fixes: eecabf567422 ("random: suppress spammy warnings about unseeded randomness")
    Fixes: d06bfd1989fe ("random: warn when kernel uses unseeded randomness")
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/char/random.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/char/random.c
    +++ b/drivers/char/random.c
    @@ -1556,7 +1556,7 @@ static void _warn_unseeded_randomness(co
    #ifndef CONFIG_WARN_ALL_UNSEEDED_RANDOM
    print_once = true;
    #endif
    - pr_notice("random: %s called from %pF with crng_init=%d\n",
    + pr_notice("random: %s called from %pS with crng_init=%d\n",
    func_name, caller, crng_init);
    }


    \
     
     \ /
      Last update: 2022-06-23 18:48    [W:4.221 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site