lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 2/2] iio: adc: ad4130: add AD4130 driver
From


On 6/23/22 18:39, Andy Shevchenko wrote:
> On Thu, Jun 23, 2022 at 5:27 PM Cosmin Tanislav <demonsingur@gmail.com> wrote:
>> On 6/20/22 21:29, Andy Shevchenko wrote:
>>> On Mon, Jun 20, 2022 at 6:27 PM Cosmin Tanislav <demonsingur@gmail.com> wrote:
>
> ...
>
>>>> + /*
>>>> + * DMA (thus cache coherency maintenance) requires the
>>>> + * transfer buffers to live in their own cache lines.
>>>> + */
>>>
>>> This is a good comment, but what fields does it apply to?
>>
>> Whatever is below it, grouped together. This is not hard to
>> understand.
>
> It's hard to understand what exactly is DMA-aware here. I see only one
> buffer that is aligned properly for DMA, the rest are not, except the
> case if all of them are going in one DMA transaction. Is this the case
> here?
>
>>>> + u8 reset_buf[AD4130_RESET_BUF_SIZE] __aligned(IIO_DMA_MINALIGN);
>
> This is aligned.
>
>>>> + u8 reg_write_tx_buf[4];
>
> This one is aligned + offset (== AD4130_RESET_BUF_SIZE + 0).
>
>>>> + u8 reg_read_tx_buf[1];
>
> This one is aligned + offset (== AD4130_RESET_BUF_SIZE + 0 + 4).
>
>>>> + u8 reg_read_rx_buf[3];
>
> This one is aligned + offset (== AD4130_RESET_BUF_SIZE + 0 + 4 + 1).
> And this is Rx.
>
>>>> + u8 fifo_tx_buf[2];
>
> Here is Tx again which is most likely is not aligned...
>
>>>> + u8 fifo_rx_buf[AD4130_FIFO_SIZE *
>>>> + AD4130_FIFO_MAX_SAMPLE_SIZE];
>>>> +};
>

This has been mentioned before by Jonathan as a reply to V6 of my
AD74413R driver.

> I'm surprised I didn't mention this before but you only need to
ensure > that any memory used for DMA is not in a cacheline with memory
used
> for other things that might change concurrently.

To my understanding, as long as the DMA buffers will all be accessed by
the same DMA-compatible SPI controller, you only need to align them so
they're not in the same cacheline with memory that will not be accessed
by the SPI controller.

\
 
 \ /
  Last update: 2022-06-23 18:15    [W:0.065 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site