Messages in this thread | | | From | Frank Li <> | Subject | RE: [PATCH -next] NTB: EPF: Fix Kconfig dependency | Date | Thu, 23 Jun 2022 15:36:38 +0000 |
| |
> -----Original Message----- > From: Ren Zhijie <renzhijie2@huawei.com> > Sent: Thursday, June 23, 2022 3:46 AM > To: kishon@ti.com; lpieralisi@kernel.org; kw@linux.com; > bhelgaas@google.com; jdmason@kudzu.us; Frank Li <frank.li@nxp.com> > Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; Ren Zhijie > <renzhijie2@huawei.com> > Subject: [PATCH -next] NTB: EPF: Fix Kconfig dependency > > If CONFIG_NTB is not set and CONFIG_PCI_EPF_VNTB is y. > > make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like > this: > > drivers/pci/endpoint/functions/pci-epf-vntb.o: In function > `epf_ntb_cmd_handler': > pci-epf-vntb.c:(.text+0x95e): undefined reference to `ntb_db_event' > pci-epf-vntb.c:(.text+0xa1f): undefined reference to `ntb_link_event' > pci-epf-vntb.c:(.text+0xa42): undefined reference to `ntb_link_event' > drivers/pci/endpoint/functions/pci-epf-vntb.o: In function `pci_vntb_probe': > pci-epf-vntb.c:(.text+0x1250): undefined reference to `ntb_register_device' > > The functions ntb_*() are defined in drivers/ntb/core.c, which need > CONFIG_NTB setting y to be build-in. > To fix this build error, add depends on NTB. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: ff32fac00d97("NTB: EPF: support NTB transfer between PCI RC and EP > connection") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> > --- [Frank Li] Acked
> drivers/pci/endpoint/functions/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/endpoint/functions/Kconfig > b/drivers/pci/endpoint/functions/Kconfig > index 362555b024e8..9beee4f0f4ee 100644 > --- a/drivers/pci/endpoint/functions/Kconfig > +++ b/drivers/pci/endpoint/functions/Kconfig > @@ -29,6 +29,7 @@ config PCI_EPF_NTB > config PCI_EPF_VNTB > tristate "PCI Endpoint NTB driver" > depends on PCI_ENDPOINT > + depends on NTB > select CONFIGFS_FS > help > Select this configuration option to enable the Non-Transparent > -- > 2.17.1
| |