lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 2/2] net: dp83822: disable rx error interrupt
    Date
    Some RX errors, notably when disconnecting the cable, increase the RCSR
    register. Once half full (0x7fff), an interrupt flood is generated. I
    measured ~3k/s interrupts even after the RX errors transfer was
    stopped.

    Since we don't read and clear the RCSR register, we should disable this
    interrupt.

    Signed-off-by: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com>
    Reviewed-by: Andrew Lunn <andrew@lunn.ch>
    Fixes: 87461f7a58ab694e638ac52afa543b427751a9d0
    ---
    drivers/net/phy/dp83822.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/net/phy/dp83822.c b/drivers/net/phy/dp83822.c
    index 95ef507053a6..8549e0e356c9 100644
    --- a/drivers/net/phy/dp83822.c
    +++ b/drivers/net/phy/dp83822.c
    @@ -229,8 +229,7 @@ static int dp83822_config_intr(struct phy_device *phydev)
    if (misr_status < 0)
    return misr_status;

    - misr_status |= (DP83822_RX_ERR_HF_INT_EN |
    - DP83822_LINK_STAT_INT_EN |
    + misr_status |= (DP83822_LINK_STAT_INT_EN |
    DP83822_ENERGY_DET_INT_EN |
    DP83822_LINK_QUAL_INT_EN);

    --
    2.25.1
    \
     
     \ /
      Last update: 2022-06-23 15:16    [W:3.543 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site