Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Thu, 23 Jun 2022 14:29:41 +0200 | Subject | Re: [PATCH v2 14/16] soundwire: Use acpi_dev_for_each_child() |
| |
On Thu, Jun 23, 2022 at 10:10 AM Vinod Koul <vkoul@kernel.org> wrote: > > On 13-06-22, 20:35, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > Instead of walking the list of children of an ACPI device directly, > > use acpi_dev_for_each_child() to carry out an action for all of > > the given ACPI device's children. > > > > This will help to eliminate the children list head from struct > > acpi_device as it is redundant and it is used in questionable ways > > in some places (in particular, locking is needed for walking the > > list pointed to it safely, but it is often missing). > > Applied, thanks
Thanks, but the export of acpi_dev_for_each_child() is being added by one of the previous patches in the series, so this one will not compile without the rest of the series in the modular case.
Is this not a problem?
| |