lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 -next] soc: mediatek: SVS: Use the new PM macros
From


On 23/06/2022 05:09, Jin Xiaoyun wrote:
> Use DEFINE_SIMPLE_DEV_PM_OPS() instead of the SIMPLE_DEV_PM_OPS()
> macro, along with using pm_sleep_ptr() as this driver doesn't handle
> runtime PM.
>
> Fix build error:
> drivers/soc/mediatek/mtk-svs.c:1515:12: error: ‘svs_resume’ defined but not used [-Werror=unused-function]
> drivers/soc/mediatek/mtk-svs.c:1481:12: error: ‘svs_suspend’ defined but not used [-Werror=unused-function]
>
> Signed-off-by: Jin Xiaoyun <jinxiaoyun2@huawei.com>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> v1->v2:
> - Remove the #ifdef CONFIG_PM guard around the suspend/resume functions
> - Use DEFINE_SIMPLE_DEV_PM_OPS along with using pm_sleep_ptr()
> ---
> drivers/soc/mediatek/mtk-svs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 606a00a2e57d..fae7376bd083 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -2381,13 +2381,13 @@ static int svs_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static SIMPLE_DEV_PM_OPS(svs_pm_ops, svs_suspend, svs_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(svs_pm_ops, svs_suspend, svs_resume);
>
> static struct platform_driver svs_driver = {
> .probe = svs_probe,
> .driver = {
> .name = "mtk-svs",
> - .pm = &svs_pm_ops,
> + .pm = pm_sleep_ptr(&svs_pm_ops),

Why do we need that? From my understanding DEFINE_SIMPLE_DEV_PM_OPS() sets
runtime_suspend_fn, runtime_resume_fn and idle_fn to NULL.

Regards,
Matthias

> .of_match_table = of_match_ptr(svs_of_match),
> },
> };
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2022-06-23 14:03    [W:0.113 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site