Messages in this thread | | | Date | Thu, 23 Jun 2022 13:18:47 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH 6/6] drm/i915/gt: Serialize TLB invalidates with GT resets |
| |
Hi Mauro,
On Wed, Jun 15, 2022 at 04:27:40PM +0100, Mauro Carvalho Chehab wrote: > From: Chris Wilson <chris.p.wilson@intel.com> > > Avoid trying to invalidate the TLB in the middle of performing an > engine reset, as this may result in the reset timing out. Currently, > the TLB invalidate is only serialised by its own mutex, forgoing the > uncore lock, but we can take the uncore->lock as well to serialise > the mmio access, thereby serialising with the GDRST. > > Tested on a NUC5i7RYB, BIOS RYBDWi35.86A.0380.2019.0517.1530 with > i915 selftest/hangcheck. > > Fixes: 7938d61591d3 ("drm/i915: Flush TLBs before releasing backing store") > > Reported-by: Mauro Carvalho Chehab <mchehab@kernel.org> > Tested-by: Mauro Carvalho Chehab <mchehab@kernel.org> > Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org> > Signed-off-by: Chris Wilson <chris.p.wilson@intel.com> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > Cc: stable@vger.kernel.org > Acked-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks, Andi
| |