Messages in this thread Patch in this message | | | From | Jiri Slaby <> | Subject | [PATCH 1/2] clk: pistachio: Fix initconst confusion | Date | Thu, 23 Jun 2022 10:32:16 +0200 |
| |
From: Andi Kleen <ak@linux.intel.com>
A variable pointing to const isn't const itself. It'd have to contain "const" keyword after "*" too. Therefore, PNAME() cannot put the strings to "rodata". Hence use __initdata instead of __initconst to fix this.
[js] more explanatory commit message.
Cc: Michael Turquette <mturquette@baylibre.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: linux-clk@vger.kernel.org Signed-off-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- drivers/clk/pistachio/clk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/pistachio/clk.h b/drivers/clk/pistachio/clk.h index f9c31e3a0e47..742e5fab00c0 100644 --- a/drivers/clk/pistachio/clk.h +++ b/drivers/clk/pistachio/clk.h @@ -34,7 +34,7 @@ struct pistachio_mux { const char **parents; }; -#define PNAME(x) static const char *x[] __initconst +#define PNAME(x) static const char *x[] __initdata #define MUX(_id, _name, _pnames, _reg, _shift) \ { \ -- 2.36.1
| |